Change in ovirt-engine[master]: core: Cleanup and UnPowerMock RunVmCommand[Test]

[lhornyak at redhat.com]

Laszlo Hornyak has submitted this change and it was merged.

Change subject: core: Cleanup and UnPowerMock RunVmCommand[Test]
......................................................................


core: Cleanup and UnPowerMock RunVmCommand[Test]

Extracted the logic of CanRunVM to an external class (VmRunHandler) in
order to decouple RunVmCommand from other commands.
Additional static methods were extracted in VmHadnler and ImagesHandler
to better decouple the command.

Once this was done, the PowerMockito could be removed from
RunVmCommandTest, and the test could generally be cleaned up for better
readability, extendability and performance.

Change-Id: I2650d70f75fddc4fae0c570273d64c0a1ae9d21a
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
10 files changed, 535 insertions(+), 528 deletions(-)

Approvals:
  Laszlo Hornyak: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5830
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2650d70f75fddc4fae0c570273d64c0a1ae9d21a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>