Change in ovirt-engine[master]: core: Cleanup in VmInfoBuilder

lhornyak at redhat.com lhornyak at redhat.com
Tue Jul 3 08:50:17 UTC 2012


Laszlo Hornyak has submitted this change and it was merged.

Change subject: core: Cleanup in VmInfoBuilder
......................................................................


core: Cleanup in VmInfoBuilder

Some java cleanup:
* Removed dependency on deprecated StringHelper class
* Solved a potentital NPE
* Made private helper methods static where possible
* Turned a method comment to javadoc format

Change-Id: I07c383278aac0178f33d0cb67d746960fb4adce9
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
1 file changed, 32 insertions(+), 27 deletions(-)

Approvals:
  Laszlo Hornyak: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I07c383278aac0178f33d0cb67d746960fb4adce9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list