Change in ovirt-engine[master]: webadmin: allow multiple spice sessions description is too l...

gchaplik at redhat.com gchaplik at redhat.com
Tue Jul 10 08:05:51 UTC 2012


Gilad Chaplik has submitted this change and it was merged.

Change subject: webadmin: allow multiple spice sessions description is too long(#834873)
......................................................................


webadmin: allow multiple spice sessions description is too long(#834873)

https://bugzilla.redhat.com/834873

In Edit VM dialog for the dektops, the Console tab contained
the checkbox "allow multiple spice sessions description is too long..."
which was too long.

Moved to Advanced Parameters section with label:
"Disable strict user checking".

This patch also contains the extraction of the logic behind
the Abstract Parameters expander button from NfsStorageView
to standalone reusable class AdvancedParametersExpander.

Change-Id: I5ee08f678ee285bf762612ba4676d258d9ddd2d5
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/AdvancedParametersExpander.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/AdvancedParametersExpander.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDesktopNewPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmServerNewPopupWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml
10 files changed, 132 insertions(+), 47 deletions(-)

Approvals:
  Tomas Jelinek: Verified
  Gilad Chaplik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5903
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5ee08f678ee285bf762612ba4676d258d9ddd2d5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>



More information about the Engine-commits mailing list