Change in ovirt-engine[master]: webadmin, userportal: GWT localization interface cleanup

[ecohen at redhat.com]

Einav Cohen has submitted this change and it was merged.

Change subject: webadmin,userportal: GWT localization interface cleanup
......................................................................


webadmin,userportal: GWT localization interface cleanup

To make oVirt UI translation process as simple as possible,
we should centralize all constant/message declarations into
few well-defined GWT localization interfaces.

This includes:
- CommonApplicationConstants/Messages for gwt-common
- ApplicationConstants for WebAdmin and UserPortal

In other words, we should avoid creating context-specific
localization interfaces, as this will add more properties
files for translators to manage.

This patch performs following cleanup:

1. Removed FeatureNotImplementedYetPopup's PopupConstants
   interface, with its methods moved to CommonApplicationConstants

2. Removed MainTabBasicListItemMessages interface, with its
   methods moved to UserPortal ApplicationConstants

Change-Id: Ibb1dbd808bad447aa53fec782dfaaa410b92451a
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/FeatureNotImplementedYetPopup.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/SystemModule.java
D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemMessages.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemView.ui.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/MainTabBasicListItemMessagesTranslator.java
8 files changed, 109 insertions(+), 119 deletions(-)

Approvals:
  Einav Cohen: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5846
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb1dbd808bad447aa53fec782dfaaa410b92451a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>