Change in ovirt-engine[master]: build: use maven deploy and move jar handling to Makefile

oschreib at redhat.com oschreib at redhat.com
Mon Jul 16 13:44:23 UTC 2012


Ofer Schreiber has submitted this change and it was merged.

Change subject: build: use maven deploy and move jar handling to Makefile
......................................................................


build: use maven deploy and move jar handling to Makefile

Currently Makefile copies intermediate files from maven
build directory, while maven is at the middle of generating
artifacts.

Currently Makefile does not produce workable image as spec
file is the one that installing the jars, it is very difficult
to pack make output and make then work on other environment.

This change does the following:
1. Uses the deploy output of maven to collect artifacts.
2. Remove the brew specific fixups.
3. Move the pom and jar installation from spec to Makefile.
4. Use 'find' to locate artifacts to support both brew and standard
   environments.

NOTES

The following poms were specified in spec but not produced
by maven deploy: restapi-interface.pom, manager-beans.pom.

The spec file produced parent.pom out of '.', while maven
deploy produces root.pom, the maven variant is used.

TESTED

make rpm - works, with the exception of the above notes.

Change-Id: I9eb8b8f60f2be71b2054582b5e898ae996f324ac
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M Makefile
M packaging/fedora/spec/ovirt-engine.spec.in
2 files changed, 73 insertions(+), 82 deletions(-)

Approvals:
  Ofer Schreiber: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/6171
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9eb8b8f60f2be71b2054582b5e898ae996f324ac
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>



More information about the Engine-commits mailing list