Change in ovirt-engine[master]: core: Validate the connectivity timeout for SetupNetworks

[masayag at redhat.com]

Moti Asayag has submitted this change and it was merged.

Change subject: core: Validate the connectivity timeout for SetupNetworks
......................................................................


core: Validate the connectivity timeout for SetupNetworks

The patch validate the value of the connectivity timeout when it is
passed by the clients for SetupNetworks command.

The legal range for the timeout is between 1 and 120 seconds. If the
check connectivity property is set to true, but no timeout is passed,
the command will be executed with the default timeout.

Change-Id: I7e03ec8dc60710780df9bf7b711d639b8c80327e
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksParametersTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetupNetworksParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
11 files changed, 31 insertions(+), 14 deletions(-)

Approvals:
  Moti Asayag: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/6200
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7e03ec8dc60710780df9bf7b711d639b8c80327e
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>