Change in ovirt-engine[master]: core, webadmin: Support diskless snapshots

derez at redhat.com derez at redhat.com
Mon Jul 23 16:00:45 UTC 2012


Daniel Erez has submitted this change and it was merged.

Change subject: core, webadmin: Support diskless snapshots
......................................................................


core, webadmin: Support diskless snapshots

This patch removes the restriction on a diskless VM, in order to align
the behavior with the current partial behavior - currently, you can
create a VM with a single disk, take a snapshot, and then remove the
disk from all the snapshots, leaving the snapshot diskless.

In the backend:
The code that finalizes the preview was extracted into a method, which
is now called from two places:
* If the snapshot has disks, it's called from EndSuccessfully(), after
  all the disks have been previewed. This is not a behavior change - the
  code that was there was simply extracted to a method.
* If the snapshot does not have any disks, it's called at the end of the
  ExecuteVmCommand, since there are no async tasks that we're waiting
  for.

In the frontend:
* The restriction on taking a snapshot of a diskless VM was removed.

Change-Id: I0193a7f4ba0e25ddeaacdf25b6a746d5ce50d698
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
2 files changed, 27 insertions(+), 47 deletions(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/6387
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0193a7f4ba0e25ddeaacdf25b6a746d5ce50d698
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>



More information about the Engine-commits mailing list