Change in ovirt-engine[master]: userportal, webadmin: make the whole tabs clickable (#783176...

vszocs at redhat.com vszocs at redhat.com
Fri Jul 27 14:07:12 UTC 2012


Vojtech Szocs has submitted this change and it was merged.

Change subject: userportal, webadmin: make the whole tabs clickable (#783176)
......................................................................


userportal, webadmin: make the whole tabs clickable (#783176)

https://bugzilla.redhat.com/783176

Solved by replacing the InlineHyperlink by Label
and enclosing the whole tab into an anchor element
(with corresponding CSS adjustments) for the
following components:

- SimpleTab [used for main and sub tabs]
- UserPortalMainTab [Basic/Extended tabs]
- VerticalTab [Extended side tabs]

Change-Id: Ia3b238cafb0e8cc6915a6b914eb7125cc901df41
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/AbstractTab.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/SimpleTab.ui.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/tab/UserPortalMainTab.ui.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/tab/VerticalTab.ui.xml
4 files changed, 107 insertions(+), 50 deletions(-)

Approvals:
  Vojtech Szocs: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5605
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3b238cafb0e8cc6915a6b914eb7125cc901df41
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>



More information about the Engine-commits mailing list