Change in ovirt-engine[master]: webadmin: Setup Host Networks dialog fixes (#811605)
vszocs at redhat.com
vszocs at redhat.com
Fri Jun 1 15:48:41 UTC 2012
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Setup Host Networks dialog fixes (#811605)
......................................................................
webadmin: Setup Host Networks dialog fixes (#811605)
https://bugzilla.redhat.com/811605
1. Bonding two NICs (NetworkOperation.BOND_WITH) no longer causes
logical network(s) assigned to bonded NICs to disappear from
the dialog
Before NICs are bonded, logical network(s) assigned to them
are first detached (unassigned). After bonding, these networks
will be present as "Unassigned Logical Networks" in the
right-hand side of the dialog.
This behavior (detaching networks from NICs before bonding)
is consistent with "add NIC to bond" dialog operation
(NetworkOperation.ADD_TO_BOND).
2. Fixed a typo in unassigned network group label
3. Removed some redundant/unnecessary methods
Change-Id: Ibd21a9dda5eca8bb954d30be28eec5cfa8cbc203
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java
4 files changed, 8 insertions(+), 18 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4757
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd21a9dda5eca8bb954d30be28eec5cfa8cbc203
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
More information about the Engine-commits
mailing list