Change in ovirt-engine[master]: core: UnPowerMock GetoVirtISOsTest

[mkublin at redhat.com]

Michael Kublin has submitted this change and it was merged.

Change subject: core: UnPowerMock GetoVirtISOsTest
......................................................................


core: UnPowerMock GetoVirtISOsTest

Removed PowerMock dependency from GetoVirtISOsTest and replaced it with
spying the query and using the new MockConfigRule.

In order to achieve this improvment, a slight refactoring to
GetoVirtISOsQuery was required so it will address the Config with lazy
getters instead of storing the config values upon class loading.
A test was added to assure that changing the functionality to lazy
getters does not break the class' behavior.

Change-Id: I3935138a255a5e91750543b35105e88d0e517084
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetoVirtISOsTest.java
2 files changed, 72 insertions(+), 48 deletions(-)

Approvals:
  Michael Kublin: Looks good to me, approved
  Allon Mureinik: Verified; Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/4930
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3935138a255a5e91750543b35105e88d0e517084
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>