Change in ovirt-engine[master]: core: Deadlock when removing host

mkublin at redhat.com mkublin at redhat.com
Sun Jun 10 14:06:13 UTC 2012


Michael Kublin has submitted this change and it was merged.

Change subject: core: Deadlock when removing host
......................................................................


core: Deadlock when removing host

The following bug was caused because of couple of parallel actions remove and activate
of the same host.
Solution lock a host during remove and activate operation.
The patch contains:
1. Introduction of lock
2. Clean up and solved pottentional NPE at ActivateVds

Change-Id: I52cd739986ff56fab6021bd0b2d5120005dbdb5b
Signed-off-by: Michael Kublin <mkublin at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java
3 files changed, 39 insertions(+), 26 deletions(-)

Approvals:
  Michael Kublin: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5188
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I52cd739986ff56fab6021bd0b2d5120005dbdb5b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list