Change in ovirt-engine[master]: core: Cleanup SetupNetworksVDSCommand part 2

mkolesni at redhat.com mkolesni at redhat.com
Mon Jun 11 07:58:47 UTC 2012


Mike Kolesnik has submitted this change and it was merged.

Change subject: core: Cleanup SetupNetworksVDSCommand part 2
......................................................................


core: Cleanup SetupNetworksVDSCommand part 2

1. Extract putIfNotEmpty method.
2. Cleanup boolean & int handling which could've been done better.
3. Extract constants for bonding keys.

Change-Id: I38b4dba9afd340e05173a21107a69216d8439bcd
Signed-off-by: Mike Kolesnik <mkolesni at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java
2 files changed, 18 insertions(+), 21 deletions(-)

Approvals:
  Mike Kolesnik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5087
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I38b4dba9afd340e05173a21107a69216d8439bcd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>



More information about the Engine-commits mailing list