Change in ovirt-engine[master]: core: simplify ValidationResult

lhornyak at redhat.com lhornyak at redhat.com
Tue Jun 12 14:49:57 UTC 2012


Laszlo Hornyak has submitted this change and it was merged.

Change subject: core: simplify ValidationResult
......................................................................


core: simplify ValidationResult

- since the field 'valid' is always false if 'message' is null and
  always true when not null, it is redundant. It is deleted.
- message field never changes, can be final
- class marked as final to make it fully immutable

Change-Id: I848ce2bd35bd97549348e7ef1a07297b0a66aa10
Signed-off-by: Laszlo Hornyak <lhornyak at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java
1 file changed, 7 insertions(+), 9 deletions(-)

Approvals:
  Laszlo Hornyak: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5280
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I848ce2bd35bd97549348e7ef1a07297b0a66aa10
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>



More information about the Engine-commits mailing list