Change in ovirt-engine[master]: core: SetupNetworksHelperTest rework
mkolesni at redhat.com
mkolesni at redhat.com
Wed Jun 13 15:26:59 UTC 2012
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: SetupNetworksHelperTest rework
......................................................................
core: SetupNetworksHelperTest rework
1. Added tests for bonds & networks basic changes & validations.
2. Got rid of tests that check internal logic since it is not supposed
to be exposed, and the tests should test the public methods only.
3. Some tests were refactored/rewritten to keep it DRY.
Change-Id: I68b69e748d216d119c0ac419358eb4b6c42d7ffe
Signed-off-by: Mike Kolesnik <mkolesni at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java
1 file changed, 410 insertions(+), 329 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5233
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68b69e748d216d119c0ac419358eb4b6c42d7ffe
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
More information about the Engine-commits
mailing list