Change in ovirt-engine[master]: core: Overhaul SetupNetworksHelper

[mkolesni at redhat.com]

Mike Kolesnik has submitted this change and it was merged.

Change subject: core: Overhaul SetupNetworksHelper
......................................................................


core: Overhaul SetupNetworksHelper

Now that tests are in order, we can rewrite SetupNetworksHelper a bit:
1. Changed fully to class fields since it looks cleaner and makes more
   sense now that tests don't rely on inner methods.
2. Some methods which were used only once got removed.
3. validations were fixed to correctly address cases where
   iface/bond/network were already processed.

Change-Id: I96266c56b0d7f2d0c6aacb45e4a39087f94258f1
Signed-off-by: Mike Kolesnik <mkolesni at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java
2 files changed, 94 insertions(+), 126 deletions(-)

Approvals:
  Mike Kolesnik: Verified
  Livnat Peer: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5234
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I96266c56b0d7f2d0c6aacb45e4a39087f94258f1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>