Change in ovirt-engine[master]: core: SetupNetworksHelper handle unmanaged VLAN

mkolesni at redhat.com mkolesni at redhat.com
Wed Jun 13 15:27:31 UTC 2012


Mike Kolesnik has submitted this change and it was merged.

Change subject: core: SetupNetworksHelper handle unmanaged VLAN
......................................................................


core: SetupNetworksHelper handle unmanaged VLAN

Code didn't handle a case of unmanaged network on VLAN that didn't
exist before, so fixed and added a test to make sure it is handled.
The unmanagedNetworks list is not necessary anymore.

Change-Id: I7d58191db622989c8de66cbd1fa1ac74fe0946bf
Signed-off-by: Mike Kolesnik <mkolesni at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java
2 files changed, 26 insertions(+), 5 deletions(-)

Approvals:
  Mike Kolesnik: Verified
  Livnat Peer: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5236
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7d58191db622989c8de66cbd1fa1ac74fe0946bf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>



More information about the Engine-commits mailing list