Change in ovirt-engine[master]: core: Change removed bonds to strings

mkolesni at redhat.com mkolesni at redhat.com
Wed Jun 13 15:27:42 UTC 2012


Mike Kolesnik has submitted this change and it was merged.

Change subject: core: Change removed bonds to strings
......................................................................


core: Change removed bonds to strings

No need to hold the whole interface, hold just the names of the bonds
that got removed.
A set was used since each bond name appears on more than one past slave
so this collection type is better for the job. In the future it will be
used to check if a bond name is contained within..

Change-Id: Id2684e962d2e99dcc8e1c609fdeef079fc290331
Signed-off-by: Mike Kolesnik <mkolesni at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java
6 files changed, 22 insertions(+), 19 deletions(-)

Approvals:
  Mike Kolesnik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5306
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2684e962d2e99dcc8e1c609fdeef079fc290331
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>



More information about the Engine-commits mailing list