Change in ovirt-engine[master]: webadmin: Setup networks- edit dialogs

gchaplik at redhat.com gchaplik at redhat.com
Mon Jun 18 14:59:22 UTC 2012


Gilad Chaplik has submitted this change and it was merged.

Change subject: webadmin: Setup networks- edit dialogs
......................................................................


webadmin: Setup networks- edit dialogs

https://bugzilla.redhat.com/show_bug.cgi?id=823881

- The "edit pencil" should be on:
  - Bond
  - networks (attached to a nic/bond)
- The bond edit should be always enabled (even if
there are no networks attached),
and contain just-
  - bond name- disabled
  - bonding mode
- The network edit should contain-
  - network name- disabled
  - boot protocol (if management- none is disabled)
  - if management- contains deafult gateway

Also contains-
- Fixed the "bond" edit form size
(Network name was cropped)
- Fixed NPE when choosing - static boot protocol
- Adding missing enum to LocalizedEnums
  (VdcActionType___UpdateNetworkToVdsInterface)

Change-Id: I16d3134a5ad14943851031b22ac6c9d7b0675d28
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostManagementPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/BondPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NicPanel.java
10 files changed, 142 insertions(+), 126 deletions(-)

Approvals:
  Gilad Chaplik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5400
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I16d3134a5ad14943851031b22ac6c9d7b0675d28
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>



More information about the Engine-commits mailing list