Change in ovirt-engine[master]: engine: filter-out already attached disks (#833076)

gchaplik at redhat.com gchaplik at redhat.com
Tue Jun 26 08:09:12 UTC 2012


Gilad Chaplik has submitted this change and it was merged.

Change subject: engine: filter-out already attached disks (#833076)
......................................................................


engine: filter-out already attached disks (#833076)

https://bugzilla.redhat.com/833076

currently, when attaching disk the gui also shows the already attached disks.
to solve that I've added a new parameter to the SP, vm guid, that filter out
all the disks that are already attached to the vm. in case the new parameter
is null, the same flow is kept (get all shared disks in DC).

Signed-off-by: Gilad Chaplik <gchaplik at redhat.com>
Change-Id: Ifa416fd6cd8e171295458b79322bb654636413f8
---
M backend/manager/dbscripts/all_disks_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAttachableDisksQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllAttachableDisks.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java
10 files changed, 70 insertions(+), 37 deletions(-)

Approvals:
  Gilad Chaplik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5680
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa416fd6cd8e171295458b79322bb654636413f8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>



More information about the Engine-commits mailing list