Change in ovirt-engine[master]: core: Remove unnecessary checks in canRemoveDiskBasedOnImage...

mkublin at redhat.com mkublin at redhat.com
Wed Jun 27 08:59:22 UTC 2012


Michael Kublin has submitted this change and it was merged.

Change subject: core: Remove unnecessary checks in canRemoveDiskBasedOnImageStorageCheck()
......................................................................


core: Remove unnecessary checks in canRemoveDiskBasedOnImageStorageCheck()

There is no need to check for VmEntityType.TEMPLATE again.
Removed check for retValue, as it is the first time and it will be true.

Change-Id: Ida64918741d5b57ba39e10c103e5ae0ceb606909
Signed-off-by: Sharad Mishra <snmishra at linux.vnet.ibm.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
1 file changed, 2 insertions(+), 5 deletions(-)

Approvals:
  Michael Kublin: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5733
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ida64918741d5b57ba39e10c103e5ae0ceb606909
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmishra at linux.vnet.ibm.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Sharad Mishra <snmishra at linux.vnet.ibm.com>



More information about the Engine-commits mailing list