Change in ovirt-engine[master]: core: removing DiskInfoList from parameters (#834527)

gchaplik at redhat.com gchaplik at redhat.com
Wed Jun 27 12:12:05 UTC 2012


Gilad Chaplik has submitted this change and it was merged.

Change subject: core: removing DiskInfoList from parameters (#834527)
......................................................................


core: removing DiskInfoList from parameters (#834527)

https://bugzilla.redhat.com/834527

in MoveOrCopyParameters the disks list is sent twice,
in DiskInfoList and in VM.DiskMap.
removing DiskInfoList, and moving all its references to Vm.DiskMap.

this change solves a bug which in REST without supplying the disksList in
import VM with collapse Snapshots, the command fails.

Change-Id: I04bf874baec89c7e2b229c1299949f1044e22c61
Signed-off-by: Gilad Chaplik <gchaplik at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyParameters.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java
4 files changed, 19 insertions(+), 39 deletions(-)

Approvals:
  Michael Kublin: Looks good to me, approved
  Gilad Chaplik: Verified


--
To view, visit http://gerrit.ovirt.org/5744
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I04bf874baec89c7e2b229c1299949f1044e22c61
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>



More information about the Engine-commits mailing list