Change in ovirt-engine[master]: userportal: Add progress animation to User Portal dialogs (#...

[vszocs at redhat.com]

Vojtech Szocs has submitted this change and it was merged.

Change subject: userportal: Add progress animation to User Portal dialogs (#745006)
......................................................................


userportal: Add progress animation to User Portal dialogs (#745006)

https://bugzilla.redhat.com/745006

UserPortalListModel completly ignored the StartProgress()
and StopProgress(). Added calling of this methods.

This patch also contains the following refactoring:
- UserPortalListModel did not used the standard
  setConfirmWindow and setWindow properties to handle popup windows
  and confirm windows. This has been changed so it uses the
  standard properties.

This patch also contains the following fixes:
- The add permission did not work at all on Templates side tab,
  because it used the PermissionListModel instead of
  UserPortalPermissionListModel

- The change CD did not work because the UserPortalListModel.ChangeCD()
  expected List<String> in callback of
  GetAllIsoImagesListByStoragePoolId instead of VdcQueryReturnValue

Change-Id: Icd627f4c6fe190b2c3cc0e4f6ca1ddacaa1a8283
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/ModelBoundPopupHandler.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateInterfaceListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalTemplateListModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/extended/template/SubTabExtendedTemplatePermissionsPresenter.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/template/SubTabExtendedTemplatePermissionsView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/template/TemplatePermissionListModelProvider.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/UserPortalListProvider.java
10 files changed, 217 insertions(+), 268 deletions(-)

Approvals:
  Vojtech Szocs: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4391
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd627f4c6fe190b2c3cc0e4f6ca1ddacaa1a8283
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>