Change in ovirt-engine[master]: core: Cleanup GetDiskConfigurationListQuery

mlipchuk at redhat.com mlipchuk at redhat.com
Sun May 20 07:54:56 UTC 2012


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: Cleanup GetDiskConfigurationListQuery
......................................................................


core: Cleanup GetDiskConfigurationListQuery

Minor clenaup in GetDiskConfigurationListQuery - replaced FQCNs with
imports, extracted constant instead of a literal 4.

In addition, added a test case to prove that no functionality was lost
in the process.

Change-Id: I9126318a7fcb6e0f01e38ff23e5409b9e99ba41a
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskConfigurationListQuery.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetDiskConfigurationListQueryTest.java
2 files changed, 130 insertions(+), 6 deletions(-)

Approvals:
  Maor Lipchuk: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4380
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9126318a7fcb6e0f01e38ff23e5409b9e99ba41a
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list