Change in ovirt-engine[master]: core: Filter GetAllAttachableDisksByPoolId

mlipchuk at redhat.com mlipchuk at redhat.com
Sun May 20 08:04:48 UTC 2012


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: Filter GetAllAttachableDisksByPoolId
......................................................................


core: Filter GetAllAttachableDisksByPoolId

Added permission filtering to GetAllAttachableDisksByPoolId, instead of
the stub implementation that was present there.

This patch includes the filtering code, a test for it, and some testing
data in fixtures.xml.

Change-Id: I04f319a036952567f1e7f9a2761ec98753052bae
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/dbscripts/all_disks_sp.sql
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
3 files changed, 37 insertions(+), 1 deletion(-)

Approvals:
  Allon Mureinik: Verified
  Maor Lipchuk: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4438
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I04f319a036952567f1e7f9a2761ec98753052bae
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list