Change in ovirt-engine[master]: core: Cleanup RoleGroupMapDAO and its tests

mkublin at redhat.com mkublin at redhat.com
Mon May 21 07:51:11 UTC 2012


Michael Kublin has submitted this change and it was merged.

Change subject: core: Cleanup RoleGroupMapDAO and its tests
......................................................................


core: Cleanup RoleGroupMapDAO and its tests

1. Used a static instance of the row mapper as per
   http://ovirt.org/wiki/Backend_Coding_Standards.

2. Replaced executeReadAndReturnMap calls to the standard executeRead
   and executeReadList.

2. Replaed * imports with FCQN imports.

Change-Id: I63a99b42978955b1c8b82ec0849f095de07c1158
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/RoleGroupMapRowMapper.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleGroupMapDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleGroupMapDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleGroupMapDAOTest.java
4 files changed, 17 insertions(+), 29 deletions(-)

Approvals:
  Michael Kublin: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4472
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I63a99b42978955b1c8b82ec0849f095de07c1158
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list