Change in ovirt-engine[master]: core: Cleanup SetupNetworksHelper part 2

masayag at redhat.com masayag at redhat.com
Mon May 21 09:22:20 UTC 2012


Moti Asayag has submitted this change and it was merged.

Change subject: core: Cleanup SetupNetworksHelper part 2
......................................................................


core: Cleanup SetupNetworksHelper part 2

Removed initialization from DB from the ctor and moved to lazy
initialization mechanism. This allows to get rid of PowerMock usage
and use plain old Mockito for tests.

Tests were adjusted to use Mockito.

Change-Id: Ie90b3dbb37ea3b40a84b0775956172482b9d13a5
Signed-off-by: Mike Kolesnik <mkolesni at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java
2 files changed, 47 insertions(+), 72 deletions(-)

Approvals:
  Moti Asayag: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4597
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie90b3dbb37ea3b40a84b0775956172482b9d13a5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>



More information about the Engine-commits mailing list