Change in ovirt-engine[master]: engine: Add ID fields to gluster brick and option

[ofrenkel at redhat.com]

Omer Frenkel has submitted this change and it was merged.

Change subject: engine: Add ID fields to gluster brick and option
......................................................................


engine: Add ID fields to gluster brick and option

- Added id column to gluster_bricks and gluster_options
- New Dao classes for these tables
- JUnit tests for the new Dao classes
- Moved methods related to DB operations on bricks and options
    from GlusterVolumeDao to the new Dao classes
- Changed existing method signatures to perform DB operations
    based on id instead of other unique keys
- Changed existing BLL commands to use the new signatures

Change-Id: I2698e1686b18a03111f94145d0eb961be85d0131
Signed-off-by: Shireesh Anjal <sanjal at redhat.com>
---
M backend/manager/dbscripts/gluster_volumes_sp.sql
A backend/manager/dbscripts/upgrade/03_01_1090_gluster_brick_option_id.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ReplaceGlusterVolumeBrickCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetGlusterVolumeOptionsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGlusterVolumeOptionCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterBrickEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeOptionEntity.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/group/gluster/AddBrick.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDao.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterOptionDao.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterOptionDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoTest.java
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterOptionDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
25 files changed, 583 insertions(+), 394 deletions(-)

Approvals:
  Shireesh Anjal: Verified
  Omer Frenkel: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2698e1686b18a03111f94145d0eb961be85d0131
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal at redhat.com>