Change in ovirt-engine[master]: engine: create gluster volume - fixed NPE

[ofrenkel at redhat.com]

Omer Frenkel has submitted this change and it was merged.

Change subject: engine: create gluster volume - fixed NPE
......................................................................


engine: create gluster volume - fixed NPE

https://bugzilla.redhat.com/823285

Create volume sometimes fails with NPE. This was happening when
the VDS command throws exception, and hence the variable errorType
remains unassigned. Modified getAuditLogTypeValue to return
GLUSTER_VOLUME_CREATE_FAILED in such cases.

Als performed following changes:
- Introduced method(s) handleVdsError(s) in GlusterCommandBase
  for standard logic to handle failure in the VDS command
- Modified executeCommand to handle VDS error if any coming
  from CreateGlusterVolumeVDSCommand

Change-Id: Ia438153a11fe952e616b1b5ddfaa0a6c1d4f6ec8
Signed-off-by: Shireesh Anjal <sanjal at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java
2 files changed, 21 insertions(+), 7 deletions(-)

Approvals:
  Shireesh Anjal: Verified
  Omer Frenkel: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4651
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia438153a11fe952e616b1b5ddfaa0a6c1d4f6ec8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal at redhat.com>