Change in ovirt-engine[master]: core: UnPowerMock AttachNetworkToVdsGroupCommandTest

mkolesni at redhat.com mkolesni at redhat.com
Tue May 22 06:31:42 UTC 2012


Mike Kolesnik has submitted this change and it was merged.

Change subject: core: UnPowerMock AttachNetworkToVdsGroupCommandTest
......................................................................


core: UnPowerMock AttachNetworkToVdsGroupCommandTest

Removed PowerMock dependency in AttachNetworkToVdsGroupCommandTest by
annonymusly extending it and mocking the relevant getXXXDAO() methods.

In order to acheive this, getNetworkDAO() was added to
AttachNetworkToVdsGroupCommand and a minor cleanup was required in
both it and VdsGroupCommandBase.

Change-Id: I11f007ddfbb81dc85198dc2953b52e841fe081e4
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommandTest.java
3 files changed, 55 insertions(+), 46 deletions(-)

Approvals:
  Mike Kolesnik: Looks good to me, approved
  Allon Mureinik: Verified


--
To view, visit http://gerrit.ovirt.org/4634
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I11f007ddfbb81dc85198dc2953b52e841fe081e4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list