Change in ovirt-engine[master]: core: Change extractRemoveNetwork return to void

mkolesni at redhat.com mkolesni at redhat.com
Thu May 24 08:07:26 UTC 2012


Mike Kolesnik has submitted this change and it was merged.

Change subject: core: Change extractRemoveNetwork return to void
......................................................................


core: Change extractRemoveNetwork return to void

The list is already kept as a field in the SetupNetworksHelper so there
is no need to have this method return a list and assign it.

Change-Id: Ief927f8bf8e18ddf8367e61554f989a6d5b6ca71
Signed-off-by: Mike Kolesnik <mkolesni at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java
2 files changed, 5 insertions(+), 7 deletions(-)

Approvals:
  Mike Kolesnik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4710
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ief927f8bf8e18ddf8367e61554f989a6d5b6ca71
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>



More information about the Engine-commits mailing list