Change in ovirt-engine[master]: core: Avoid aborting the current TX when destroying stateles...

ofrenkel at redhat.com ofrenkel at redhat.com
Thu May 24 12:38:21 UTC 2012


Omer Frenkel has submitted this change and it was merged.

Change subject: core: Avoid aborting the current TX when destroying stateless VM
......................................................................


core: Avoid aborting the current TX when destroying stateless VM

problem:
 when destroying a VM some actions taken in new transaction
 which invokes internal commands that can abort it.

solution:
 invoke the code with the posiblle side-effects in a new transaction. the outcome of this flow
 is not relevant, we just need to isolate it in a new TX to prevent rollbacking the current.

backgroud:
 When a stateless VM is destroyed we invoke the a method that treats a VM stop
 in the event listener. This direct invocation of the event listerner is exclusive to the Destroy command
 for usually, the treatment is invoked when the VM status, which is reported by VDSM, is changing.
 Since the VM has been destoryed already its not reported anymore and the proccessOnVmStop must be called manually.

Change-Id: I623e118420a748d091699049242a050248ca1ce1
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java
1 file changed, 25 insertions(+), 8 deletions(-)

Approvals:
  Roy Golan: Verified
  Omer Frenkel: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4656
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I623e118420a748d091699049242a050248ca1ce1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>



More information about the Engine-commits mailing list