Change in ovirt-engine[master]: core: UnPowerMock UpdateVmDiskCommandTest

lhornyak at redhat.com lhornyak at redhat.com
Fri May 25 10:08:33 UTC 2012


Laszlo Hornyak has submitted this change and it was merged.

Change subject: core: UnPowerMock UpdateVmDiskCommandTest
......................................................................


core: UnPowerMock UpdateVmDiskCommandTest

Removed PowerMock dependecy from UpdateVmDiskCommandTest, and replaced
it with spying some DAO accessors.

In order to facilitate this change some refactoring was required in
VmCommand and AbstractDiskVmCommand to expose these methods.

Change-Id: I580a52a31e08214ee07e14c33d0ad1ee2320d22b
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
4 files changed, 71 insertions(+), 66 deletions(-)

Approvals:
  Laszlo Hornyak: Verified; Looks good to me, approved
  Allon Mureinik: Verified


--
To view, visit http://gerrit.ovirt.org/4689
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I580a52a31e08214ee07e14c33d0ad1ee2320d22b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list