Change in ovirt-engine[master]: core: UnPowerMock RestoreAllSnapshotCommandTest

lhornyak at redhat.com lhornyak at redhat.com
Fri May 25 11:09:44 UTC 2012


Laszlo Hornyak has submitted this change and it was merged.

Change subject: core: UnPowerMock RestoreAllSnapshotCommandTest
......................................................................


core: UnPowerMock RestoreAllSnapshotCommandTest

Removed PowerMock dependency from RestoreAllSnapshotCommandTest and
replaced it by spying the command.

In order to achieve this improvement, some minor refactoring was
required in RestoreAllSnapshotsCommand and VmCommand.

Change-Id: I75c9f5952b318e0efaed0b8c83ccfe74475e62be
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java
3 files changed, 63 insertions(+), 46 deletions(-)

Approvals:
  Laszlo Hornyak: Verified; Looks good to me, approved
  Allon Mureinik: Verified


--
To view, visit http://gerrit.ovirt.org/4773
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I75c9f5952b318e0efaed0b8c83ccfe74475e62be
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list