Change in ovirt-engine[master]: core: UnPowerMock GetAllDisksByVmIdQueryTest

lhornyak at redhat.com lhornyak at redhat.com
Fri May 25 12:15:46 UTC 2012


Laszlo Hornyak has submitted this change and it was merged.

Change subject: core: UnPowerMock GetAllDisksByVmIdQueryTest
......................................................................


core: UnPowerMock GetAllDisksByVmIdQueryTest

Removed PowerMock dependency from GetAllDisksByVmIdQueryTest and
replaced it with spying the query.

In order to achieve this improvemnt a minor refactor was requred in
GetAllDisksByVmIdQuery to expose the getAllImageSnapshots(DiskImage)
method.

Change-Id: Ib1adfb92d3b7f88aa7527faa9d2572bb65340c73
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQueryTest.java
2 files changed, 12 insertions(+), 17 deletions(-)

Approvals:
  Laszlo Hornyak: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4778
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1adfb92d3b7f88aa7527faa9d2572bb65340c73
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list