Change in ovirt-engine[master]: userportal: SpiceUsbAutoShare configuration is ignored (#767...

[vszocs at redhat.com]

Vojtech Szocs has submitted this change and it was merged.

Change subject: userportal: SpiceUsbAutoShare configuration is ignored (#767081)
......................................................................


userportal: SpiceUsbAutoShare configuration is ignored (#767081)

https://bugzilla.redhat.com/767081

While "SpiceUsbAutoShare" is set to true in vdc_options, the
Auto-Share USB checkbox in the user portal is not checked by default.

The problem was, that the SpiceUsbAutoShare was completly ignored.
Solved by adding the reading of this value to the
Configurator.updateSpiceUsbAutoShare() method which is called from the
constructor of SpiceConsoleModel via of the Configurator.Configure().

In most cases this value will be read from the cache, but for the
first time it will really reach out to the DB and it can take a
while. That is the reason, why the ConsolePopupPresenterWidget
listens to UsbAutoShareChangedEvent and re-renders the popup
if such an event arrives.

Change-Id: Iaf72cb10aeaf0c7bafca17ed91ac0fd330501d80
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceInterfaceImpl.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpice.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/console/ConsolePopupPresenterWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java
8 files changed, 87 insertions(+), 26 deletions(-)

Approvals:
  Vojtech Szocs: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4653
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf72cb10aeaf0c7bafca17ed91ac0fd330501d80
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>