Change in ovirt-engine[master]: core: Fix handling same network on different nics

[mkolesni at redhat.com]

Mike Kolesnik has submitted this change and it was merged.

Change subject: core: Fix handling same network on different nics
......................................................................


core: Fix handling same network on different nics

The old check would never catch this scenario, since the
networksOverBond list was locally initiated to an empty list.

The check should be simple - network can be defined only once on some
interface.

Clarification:
If it is a bond interface then it can't be defined on the
bond slaves.
If it is a VLAN then it can't be defined on the VLAN's NIC.

Change-Id: I4cb7f7c0c7cc7c2240b72e411d81c2ddbc561766
Signed-off-by: Mike Kolesnik <mkolesni at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java
2 files changed, 1 insertion(+), 7 deletions(-)

Approvals:
  Mike Kolesnik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4713
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4cb7f7c0c7cc7c2240b72e411d81c2ddbc561766
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>