Change in ovirt-engine[master]: webadmin, userportal: PlaceManager refactoring

gchaplik at redhat.com gchaplik at redhat.com
Mon May 28 10:49:46 UTC 2012


Gilad Chaplik has submitted this change and it was merged.

Change subject: webadmin,userportal: PlaceManager refactoring
......................................................................


webadmin,userportal: PlaceManager refactoring

WebAdmin's default main section place should depend on current
"UI mode" setting (related to mode-specific UI feature).

For example, in GlusterOnly UI mode, "Virtual Machines" main tab
is not available and the place manager should therefore redirect
the user into different main tab after logging in.

This patch refactors ApplicationPlaceManager, related classes
and GIN configuration bindings.

WebAdmin's UiMode -> default place resolution logic is in
WebAdminPlaceManager.resolveMainSectionPlace() method.

Change-Id: I50c4005ec8e046c63bc22e8410cdd3f26e5908f2
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/place/ApplicationPlaceManager.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/SystemModule.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/place/UserPortalPlaceManager.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/DefaultMainSectionExtendedPlace.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/SystemModule.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/WebAdminPlaceManager.java
7 files changed, 88 insertions(+), 38 deletions(-)

Approvals:
  Gilad Chaplik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4708
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I50c4005ec8e046c63bc22e8410cdd3f26e5908f2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>



More information about the Engine-commits mailing list