Change in ovirt-engine[master]: core: Fixing http connection leak at proxy for SPM

[mkublin at redhat.com]

Michael Kublin has submitted this change and it was merged.

Change subject: core: Fixing http connection leak at proxy for SPM
......................................................................


core: Fixing http connection leak at proxy for SPM

The following patch will fix a connection leak which we have
during nullify of IrsProxy.
A proxy is representating spm, each time that spm moved to maintaince or
replaced we change a proxy, but coneection of http client was not closed.
Also there are was some interesting code: set proxy to null and after that
to call Dispose() method, where to shutdown connections when a proxy is not null -
magic.
Also I removed some one lines method, they don't help, and caused for a lot bugs
especilaly at that class

Change-Id: Iec0941108ae66c6174626915a45f02ab0996cfee
Signed-off-by: Michael Kublin <mkublin at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
1 file changed, 22 insertions(+), 26 deletions(-)

Approvals:
  Michael Kublin: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/9116
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iec0941108ae66c6174626915a45f02ab0996cfee
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>