Change in ovirt-engine[master]: webadmin, engine: Add validation for snapshot description le...

masayag at redhat.com masayag at redhat.com
Tue Nov 13 09:40:08 UTC 2012


Moti Asayag has submitted this change and it was merged.

Change subject: webadmin, engine: Add validation for snapshot description length
......................................................................


webadmin, engine: Add validation for snapshot description length

Add validation which checks that the length of the snapshot
description does not exceed 4000 (GENERAL_MAX_SIZE) characters
at the webadmin dialog for creating snapshot

Add validation which checks that the length of the
snapshot description does not exceed GENERAL_MAX_SIZE
for CreateAllSnapshhotsFromVmCommand in the engine

Change-Id: I780eec76b6eb576d28b3650f4d34384594a8044d
Bug-Url: https://bugzilla.redhat.com/871029
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllSnapshotsFromVmParameters.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 15 insertions(+), 1 deletion(-)

Approvals:
  Moti Asayag: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/9011
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I780eec76b6eb576d28b3650f4d34384594a8044d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list