Change in ovirt-engine[master]: core: MockEJBStrategyRule

amureini at redhat.com amureini at redhat.com
Sun Nov 25 09:14:20 UTC 2012


Allon Mureinik has submitted this change and it was merged.

Change subject: core: MockEJBStrategyRule
......................................................................


core: MockEJBStrategyRule

Introducing MockEJBStrategyRule to provide an easy and straight forward
way to mock EJBs and resources in bll tests.

This patch includes the new @Rule and refactors all the tests with
proprietary solutions for such mocking to use the new, standard way.

Change-Id: Ib0ae1b2c56f2b189729883bf34da9a295a8ae9d6
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java
D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ExecuteTransactionAnswer.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterManagerTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lock/InMemoryLockManagerTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainTest.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MockEJBStrategyRule.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java
10 files changed, 123 insertions(+), 173 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/9401
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0ae1b2c56f2b189729883bf34da9a295a8ae9d6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>



More information about the Engine-commits mailing list