Change in ovirt-engine[master]: engine: Query getdisksvmguid caused postmaster processes to ...

[mkublin at redhat.com]

Michael Kublin has submitted this change and it was merged.

Change subject: engine: Query getdisksvmguid caused postmaster processes to consume constantly 100%cpu.
......................................................................


engine: Query getdisksvmguid caused postmaster processes to consume constantly 100%cpu.

The following bug occurrs because of the following query being run from
GetVmStatsVDSCommand every running VM in the system. The run is cyclic and runs in infinitive loop.
I don't see reason of that query, update of dynamic data ofor disc is done under lock, in worst case
the dynamic data will be updated with wrong values, in next run which occurring every 4 seconds, the
disk will be updated with correct values.
I think we can live with wrong values for 4 seconds in case of race
The change reduced CPU of machine with DB from 100% to 30%, which is still a high, but better

Change-Id: I9ef4a24908a75ab4fc1f02eed7c97a7125a5db41
Bug-Url: https://bugzilla.redhat.com/879930
Signed-off-by: Michael Kublin <mkublin at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 22 insertions(+), 37 deletions(-)

Approvals:
  Michael Kublin: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/9468
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9ef4a24908a75ab4fc1f02eed7c97a7125a5db41
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>