Change in ovirt-engine[master]: webadmin: Time zones contained couple of empty lines (#85069...

[tjelinek at redhat.com]

Tomas Jelinek has submitted this change and it was merged.

Change subject: webadmin: Time zones contained couple of empty lines (#850696)
......................................................................


webadmin: Time zones contained couple of empty lines (#850696)

https://bugzilla.redhat.com/850696

The probelm was that the selected item was set up like this:
... new KeyValuePairCompat<String, String>(...gettime_zone(), "")
UpdateTimeZone()

Where the UpdateTimeZone was an asynchronous request to get the
time zones and set them up and select the correct one.

Changed in a way, that the UpdateTimeZone now gets as an
argument the time zone to set the selected item to, and
after it fetches the values, it sets the selected time zone
in this way:
- if the argument is provided, set the selected time zone
  to it
- if the argument is not provided, checks if something has
  already been selected, and if yes, selects it again
- if none of the above is true, then selects the first of
  the time zones

Change-Id: Iad95c26566a0e846f6f7712ce122210e7fc758b9
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
7 files changed, 37 insertions(+), 41 deletions(-)

Approvals:
  Tomas Jelinek: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/8285
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iad95c26566a0e846f6f7712ce122210e7fc758b9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>