Change in ovirt-engine[master]: core: break down spaghetti-code in VdsSelector

lhornyak at redhat.com lhornyak at redhat.com
Tue Oct 9 16:06:09 UTC 2012


Laszlo Hornyak has submitted this change and it was merged.

Change subject: core: break down spaghetti-code in VdsSelector
......................................................................


core: break down spaghetti-code in VdsSelector

- This is a minor cleanup that breaks down the big if-else statement
  into validator objects, and just iterates over the validator objects.
  No functional change in VdsSelector.

Change-Id: I6b4535e050790434b12180fc0bae55dd26fe43b5
Signed-off-by: Laszlo Hornyak <lhornyak at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java
1 file changed, 117 insertions(+), 36 deletions(-)

Approvals:
  Laszlo Hornyak: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/8401
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b4535e050790434b12180fc0bae55dd26fe43b5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>



More information about the Engine-commits mailing list