Change in ovirt-engine[master]: core: simplify 'is null' sql expression

lhornyak at redhat.com lhornyak at redhat.com
Mon Oct 15 16:45:37 UTC 2012


Laszlo Hornyak has submitted this change and it was merged.

Change subject: core: simplify 'is null' sql expression
......................................................................


core: simplify 'is null' sql expression

The original logic generates conditional expressions like

(tab.col = null or tab.col is null)

tab.col = null never evaluates to true on known sql database
engines, so the generated expression can be simplified with this.
The new generated condition will be just

(tab.col is null)

Change-Id: I6d186f0f354026086a7f7039deaca1c236cfc7be
Signed-off-by: Laszlo Hornyak <lhornyak at redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Laszlo Hornyak: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6d186f0f354026086a7f7039deaca1c236cfc7be
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list