Change in ovirt-engine[master]: engine: Wrong templates displayed for iscsi DC

tjelinek at redhat.com tjelinek at redhat.com
Fri Oct 19 11:28:27 UTC 2012


Tomas Jelinek has submitted this change and it was merged.

Change subject: engine: Wrong templates displayed for iscsi DC
......................................................................


engine: Wrong templates displayed for iscsi DC

1. Make sure you have  iscsi,nfs local DCs.
2. Create templates for each DC
3. Try to create a pool for iscsi DC

Wrong templates are listed in dropdown menu. The problem was caused by NPE in
the Template_SelectedItemChanged method of the NewPoolModelBehavior class. The
template is previously set to null in the ItemsChanged method of the ListModel
class. Fixed by adding check for null in the Template_SelectedItemChanged
method.

Change-Id: I1dbee5e31ec945b8ee07407cac5045d7cf8c39bf
Signed-off-by: Frantisek Kobzik <fkobzik at redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=863149
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Tomas Jelinek: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/8648
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1dbee5e31ec945b8ee07407cac5045d7cf8c39bf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>



More information about the Engine-commits mailing list