Change in ovirt-engine[master]: userportal: VMs are not refreshed after edit

tjelinek at redhat.com tjelinek at redhat.com
Fri Oct 19 11:32:11 UTC 2012


Tomas Jelinek has submitted this change and it was merged.

Change subject: userportal: VMs are not refreshed after edit
......................................................................


userportal: VMs are not refreshed after edit

In PUP: edit VM, click OK, edit VM again

The values will still be the old ones and you need
to wait until the next refresh cycle to actually
get them refreshed.

The refreshing after edit works like this:
When the popup is closed (the window model is set
to null), the ModelBoundPopupHandler
catches this event and calls the hideAndClearPopup
which calls the force refresh. This ensures,
that after the values are edited, the screen
contains the updated data.

The problem was, that the UserPortalListModel
called the cancel() method right after the
command to update the values has been sent to the server.
Before the call returned, the force refresh
tried to get the updated data, but they
was not necessarily updated yet.

Changed to call the cancel() after the
specific commands returns to ensure that the
data are actually modified.

Change-Id: If37dfffaafd72e385dfed03b3aafbd07cd82ba2d
Bug-Url: https://bugzilla.redhat.com/864059
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
2 files changed, 6 insertions(+), 24 deletions(-)

Approvals:
  Tomas Jelinek: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/8610
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If37dfffaafd72e385dfed03b3aafbd07cd82ba2d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>



More information about the Engine-commits mailing list