Change in ovirt-engine[master]: core: Add null/empty support to IP Address pattern (#852076)

masayag at redhat.com masayag at redhat.com
Sun Sep 2 13:27:20 UTC 2012


Moti Asayag has submitted this change and it was merged.

Change subject: core: Add null/empty support to IP Address pattern (#852076)
......................................................................


core: Add null/empty support to IP Address pattern (#852076)

https://bugzilla.redhat.com/852076

The IP Address pattern support also empty string or nulls as values
which might be sent in the parameter classes. Also added a unit-test to
assure the pattern well-covers the various addresses.

Change-Id: If8d38ebf880c72d86f956f7c08aefa12e1894109
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java
A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/IPAddressPatternTest.java
2 files changed, 90 insertions(+), 1 deletion(-)

Approvals:
  Moti Asayag: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7634
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If8d38ebf880c72d86f956f7c08aefa12e1894109
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Muli Salem <msalem at redhat.com>



More information about the Engine-commits mailing list