Change in ovirt-engine[master]: core: Add validation for IP Addresses (#852076)

masayag at redhat.com masayag at redhat.com
Sun Sep 2 13:27:19 UTC 2012


Moti Asayag has submitted this change and it was merged.

Change subject: core: Add validation for IP Addresses (#852076)
......................................................................


core: Add validation for IP Addresses (#852076)

https://bugzilla.redhat.com/852076

Any IP address being sent from the clients to the engine is being
verifies to its correct format. Clients are allowed to pass empty string
or null values or a valid IP address.

Change-Id: I883deb575455c0cc2d0b7d45619a007421766df7
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddBondParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddNetworkStoragePoolParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachNetworkToVdsGroupParameter.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachNetworkToVdsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateNetworkToVdsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Network.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNetworkInterface.java
7 files changed, 51 insertions(+), 6 deletions(-)

Approvals:
  Moti Asayag: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I883deb575455c0cc2d0b7d45619a007421766df7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Muli Salem <msalem at redhat.com>



More information about the Engine-commits mailing list