Change in ovirt-engine[master]: core: AddImageFromScratch's ConcreteCreateTask

derez at redhat.com derez at redhat.com
Sun Sep 16 08:21:12 UTC 2012


Daniel Erez has submitted this change and it was merged.

Change subject: core: AddImageFromScratch's ConcreteCreateTask
......................................................................


core: AddImageFromScratch's ConcreteCreateTask

Removed the ConcreteCreateTask from the AddImageFromScratchCommand. The
code is a duplication of the same method introduced to CommandBase,
and the task type is createVolume, the same as in CreateImageCommand,
which it extends.

Change-Id: Iec993e6a365eca913e5739a4cc3165854803c5e7
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java
2 files changed, 3 insertions(+), 19 deletions(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7793
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iec993e6a365eca913e5739a4cc3165854803c5e7
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list