Change in ovirt-engine[master]: core: Refactor getDiskDAO to getDiskDao

yzaslavs at redhat.com yzaslavs at redhat.com
Sun Sep 23 08:12:42 UTC 2012


Yair Zaslavsky has submitted this change and it was merged.

Change subject: core: Refactor getDiskDAO to getDiskDao
......................................................................


core: Refactor getDiskDAO to getDiskDao

To fix FindBugs issue -
VERY confusing to have methods org.ovirt.engine.core.bll.AbstractDiskVmCommand.getDiskDao() and org.ovirt.engine.core.bll.VmCommand.getDiskDAO()

Change-Id: Icb04449ed3837d6d7b8deef4edd63c93c4e55848
Signed-off-by: Sharad Mishra <snmishra at linux.vnet.ibm.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
5 files changed, 8 insertions(+), 8 deletions(-)

Approvals:
  Yair Zaslavsky: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/8100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icb04449ed3837d6d7b8deef4edd63c93c4e55848
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmishra at linux.vnet.ibm.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra at linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list